Re: [PATCH] umount after bad chdir

From: viro
Date: Wed Apr 14 2004 - 10:25:14 EST


On Wed, Apr 14, 2004 at 11:13:13PM +0800, raven@xxxxxxxxxx wrote:
> On Wed, 14 Apr 2004 raven@xxxxxxxxxx wrote:
>
> > > Mind you, chdir() patch in -mm is broken in a lot of other ways - e.g.
> > > it assumes that another thread sharing ->fs with us won't call chdir()
> > > in the wrong moment...
> >
> > Thanks for your interest Al.
> >
> > I see your point (I think).
> >
> > If I understand you correctly (please explain if I don't) I need to lock
> > the ->fs struct.
>
> Mmm ... doesn't look much good in the light of Als comment.
>
> Looks like it's not possible to take the lock for long enough even if I
> could.
>
> Lets have some comments, criticisms or suggestions please.

Why do you need to assign pwd before revalidation?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/