Re: [PATCH] fix 4k irqstacks on x86 (and add voyager support)

[Zwane Mwaikambo]

On Thu, 15 Apr 2004, James Bottomley wrote:

> On Thu, 2004-04-15 at 10:29, Zwane Mwaikambo wrote:
> > > There's a bug in the x86 code in that it sets the boot CPU to zero.
> > > This isn't correct since some subarch's use physically indexed CPUs.
> > > However, subarchs have either set the boot cpu before irq_INIT() (or
> > > just inherited the default zero from INIT_THREAD_INFO()), so it's safe
> > > to believe current_thread_info()->cpu about the boot cpu.
> >
> > There is also smp_boot_cpus() which sets it to zero yet again later on =)
>
> That's PC specific, not subarch generic, so it doesn't matter to me.

Sorry for being a bit slow here, doesn't this affect voyager at all?

init/main.c:init()
	smp_prepare_cpus()

arch/i386/kernel/smpboot.c:smp_prepare_cpus()
	smp_boot_cpus();

obj-$(CONFIG_X86_SMP)           += smp.o smpboot.o
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/