Re: [PATCH] sort out CLOCK_TICK_RATE usage, 2nd try [0/3]

From: Geert Uytterhoeven
Date: Fri Apr 16 2004 - 04:30:19 EST


On Wed, 14 Apr 2004, Matthew Wilcox wrote:
> On Tue, Apr 13, 2004 at 09:58:33PM +0000, Thorsten Kranzkowski wrote:
> > Arch maintainers please have a look whether I got the constants right or
> > if your architecture has a PIC or speaker at all.
>
> parisc certainly doesn't. i'd start by making this change for alpha,
> x86 and x86_64 and make the PC speaker depend on (ALPHA || X86 || X86_64)
> then other arches can take it from there if they want to supoprt the
> pc speaker.

M68k has m68kspkr, which beeps through the m68k beep abstraction.

The only reason there's a 1193182 in drivers/input/misc/m68kspkr.c is for
userspace compatibility with ia32. So please don't introduce
include/asm-m68k/8253pit.h and keep CLOCK_TICK_RATE for m68k like it is.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/