Re: [PATCH] psmouse fixes for 2.6.5

From: Dmitry Torokhov
Date: Wed Apr 21 2004 - 02:11:18 EST


Taking it off list for now...

On Wednesday 21 April 2004 01:48 am, Kim Holviala wrote:
> On Wednesday 21 April 2004 05:17, Dmitry Torokhov wrote:
>
> > > > > - support for Targus Scroller mice (from my last weeks patch)
> > > >
> > > > Why do you have Tragus as a config option - just set the protocol mask
> > > > correctly by default...
>
> It's not a config option, I just have a little note on the Kconfig file for
> those that read the help pages.

You right, sorry... I just glanced over it in the morning, saw Kconfig being
changed and jumped to a conclusion. The only excuse: -ENOCOFFEE :)

I would recommend splitting your patch in 3 pieces - one for reset, one for
targus and one for protocol selection. This way its easuier for Vojtech to
apply them.

Question - why did you kill the protocol names array?

Btw, I am also trying to work in that area, might be beneficial if we combine
our efforts. I just posted bunch of changes on the list, you may also grab
them with

bk pull bk://dtor.bkbits.net/input

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/