[PATCH] Return more useful error number when acls are too large

[Andreas Gruenbacher]

Hello,

could you please add this to mainline? Getting EINVAL when an acl
becomes too large is quite confusing.



Index: linux-2.6.6-rc2/fs/ext2/acl.c
===================================================================
--- linux-2.6.6-rc2.orig/fs/ext2/acl.c	2004-04-20 23:29:46.000000000 +0200
+++ linux-2.6.6-rc2/fs/ext2/acl.c	2004-04-26 11:45:59.724792120 +0200
@@ -256,7 +256,7 @@
 	}
  	if (acl) {
 		if (acl->a_count > EXT2_ACL_MAX_ENTRIES)
-			return -EINVAL;
+			return -ENOSPC;
 		value = ext2_acl_to_disk(acl, &size);
 		if (IS_ERR(value))
 			return (int)PTR_ERR(value);
Index: linux-2.6.6-rc2/fs/ext3/acl.c
===================================================================
--- linux-2.6.6-rc2.orig/fs/ext3/acl.c	2004-04-20 23:28:53.000000000 +0200
+++ linux-2.6.6-rc2/fs/ext3/acl.c	2004-04-26 11:46:05.143968280 +0200
@@ -260,7 +260,7 @@
 	}
  	if (acl) {
 		if (acl->a_count > EXT3_ACL_MAX_ENTRIES)
-			return -EINVAL;
+			return -ENOSPC;
 		value = ext3_acl_to_disk(acl, &size);
 		if (IS_ERR(value))
 			return (int)PTR_ERR(value);


Thanks,
-- 
Andreas Gruenbacher <agruen@xxxxxxx>
SUSE Labs, SUSE LINUX AG

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/