Re: [PATCH] prevent module unloading for legacy IDE chipset drivers

From: Bartlomiej Zolnierkiewicz
Date: Mon Apr 26 2004 - 09:52:41 EST


On Monday 26 of April 2004 15:50, Erik Mouw wrote:
> On Thu, Apr 22, 2004 at 04:35:12PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Thursday 22 of April 2004 12:33, Erik Mouw wrote:
> > > What makes IDE sufficiently different from SCSI that we can't unload
> > > IDE host drivers?
> >
> > - no reference counting
> > - lack of release() method
> > - insufficient locking
>
> Do you plan to fix the module unloading in the current code, or is it
> easier to write a new driver based on libata (assuming it has been
> fixed in libata)? If I understood Jeff's latest libata update

I'm going to fix it but doing it properly requires major changes in IDE
code (ie. get rid of static &ide_hwifs[]) but it's happening slowly.

> correctly, it should be possible Real Soon Now [tm], right?

BTW I think there is a common misunderstanding about libata:
it will not replace IDE drivers any time soon.

I want to rewrite+merge current IDE code with libata during 2.7
(and yes, legacy naming and ordering will be preserved!).

I hope nobody starts rewriting existing IDE drivers for libata and pushing
them upstream -> it will mean maintenance problems much bigger than OSS+ALSA.

However writing _new_ libata driver for 'exotic' PATA hardware is OK.

Cheers,
Bartlomiej

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/