Re: Bug#234976: kernel-source-2.6.4: Software Suspend doesn't work

[Nigel Cunningham]

Hi.

On Wed, 28 Apr 2004 01:16:26 +0200, Pavel Machek <pavel@xxxxxxx> wrote:

> Hi!
>
> > On Tue, 27 Apr 2004 23:52:36 +0200, Pavel Machek <pavel@xxxxxxx> wrote:
> >
> > >+#ifdef CONFIG_SOFTWARE_SUSPEND
> > >+	{
> > >+		extern char swsusp_pg_dir[PAGE_SIZE];
> > >+		memcpy(swsusp_pg_dir, swapper_pg_dir, PAGE_SIZE);
> > >+	}
> > >+#endif
> >
> > Would you consider making that #ifdef CONFIG_PM, so that I could use it
> > too without needing to patch it further? (I'm using
> > CONFIG_SOFTWARE_SUSPEND2 if you prefer something more specific).
>
> Well, swsusp_pg_dir is defined in kernel/power/cpu.c, so it is not as
> easy as defining it CONFIG_PM.

Ah. Of course. Humble apologies.

> What about make CONFIG_SOFTWARE_SUSPEND2 defining
> CONFIG_SOFTWARE_SUSPEND, too? We want the merged, anyway...

Could do. And on the top of merging, sorry for the delays I'm getting  
there. I figured out yesterday what was holding me back with getting SMP &  
HighMem going under 2.6. It was really simple: the compile was using -O2.  
A quick change to the Makefile and I can now use a C file as I do with 2.4.

Regards,

Nigel
--
Nigel Cunningham
C/- Westminster Presbyterian Church Belconnen
61 Templeton Street, Cook, ACT 2614, Australia.
+61 (2) 6251 7727 (wk)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/