Re: [PATCH] Trivial fix for hid-tmff driver

From: Vojtech Pavlik
Date: Thu Apr 29 2004 - 14:43:44 EST


On Thu, Apr 29, 2004 at 02:26:56PM -0500, Zinx Verituse wrote:
> Well, this has been a problem for quite some time due to a change in
> the list code way back when, and my mails don't seem to be getting
> through to Vojtech Pavlik, so here's the patch.. The problem may still
> exist in the other drivers..

I'll get it into my tree asap.

>
> --
> Zinx Verituse http://zinx.xmms.org/

> diff -ru linux-2.6.5.orig/drivers/usb/input/hid-tmff.c linux-2.6.5/drivers/usb/input/hid-tmff.c
> --- linux-2.6.5.orig/drivers/usb/input/hid-tmff.c 2003-10-25 13:43:59.000000000 -0500
> +++ linux-2.6.5/drivers/usb/input/hid-tmff.c 2003-12-18 01:00:41.000000000 -0600
> @@ -110,7 +110,7 @@
> {
> struct tmff_device *private;
> struct list_head *pos;
> - struct hid_input *hidinput = list_entry(&hid->inputs, struct hid_input, list);
> + struct hid_input *hidinput = list_entry(hid->inputs.next, struct hid_input, list);
>
> private = kmalloc(sizeof(struct tmff_device), GFP_KERNEL);
> if (!private)


--
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/