Re: 2.4.27-pre2: tg3: there's no WARN_ON in 2.4

[Eyal Lebedinsky]

Marc-Christian Petersen wrote:
> On Tuesday 04 May 2004 22:46, Adrian Bunk wrote:
>
> Hi Adrian,
>
>
> > drivers/net/net.o(.text+0x60293): In function `tg3_get_strings':
> > : undefined reference to `WARN_ON'
> > make: *** [vmlinux] Error 1
> > There's no WARN_ON in 2.4.
>
>
> yep. Either we backport WARN_ON ;) or simply do the attached.
>
> --- old/drivers/net/tg3.c	2004-05-04 14:30:22.000000000 +0200
> +++ new/drivers/net/tg3.c	2004-05-04 14:49:58.000000000 +0200
> @@ -51,6 +51,10 @@
>  #define TG3_TSO_SUPPORT	0
>  #endif
>  
> +#ifndef WARN_ON
> +#define	WARN_ON(x)	do { } while (0)
> +#endif

Related but off topic. Do people find the ab#define	WARN_ON(x)
a macro acceptable? The fact is that not mentioning 'x' means any
side-effects are not executed, meaning the author must take special
care when using this macro.

Maybe something like
	#define	WARN_ON(x)	do {(void)(x);} while (0)
which may still attract a warning about "stmt has no effect" (not
sure).

--
Eyal Lebedinsky (eyal@xxxxxxxxxxxxxx) <http://samba.org/eyal/>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/