Re: Force IDE cache flush on shutdown

[Christoph Hellwig]

On Thu, May 06, 2004 at 12:46:38PM +0200, Arjan van de Ven wrote:
> Ok the following does the trick for me. Better?
> 
> diff -purN linux-2.6.5/drivers/ide/ide-disk.c linux/drivers/ide/ide-disk.c
> --- linux-2.6.5/drivers/ide/ide-disk.c	2004-05-06 10:56:55.672139712 +0200
> +++ linux/drivers/ide/ide-disk.c	2004-05-06 11:09:19.470065240 +0200
> @@ -1820,6 +1820,23 @@ static int idedisk_revalidate_disk(struc
>  	return 0;
>  }
>  
> +static int ide_drive_shutdown(struct device * dev)
> +{
> +	ide_drive_t * drive = container_of(dev,ide_drive_t,gendev);
> +	
> +	/* safety checks */
> +	if (!drive->present)
> +		return 0;
> +	if (drive->media != ide_disk)
> +		return 0;
> +	printk("Flushing cache: %s \n", drive->name);
> +	ide_cacheflush_p(drive);
> +	/* give the hardware time to finish; it may return prematurely to cheat */
> +	mdelay(300);
> +	return 0;
> +}

Looks good to mz limited understanding of the ide code :)

>  static struct block_device_operations idedisk_ops = {
>  	.owner		= THIS_MODULE,
>  	.open		= idedisk_open,
> @@ -1881,6 +1898,7 @@ static void __exit idedisk_exit (void)
>  
>  static int idedisk_init (void)
>  {
> +	idedisk_driver.gen_driver.shutdown = ide_drive_shutdown;

isn't idedisk_driver initialized statically somewhere?  You should probably
add

	.gen_driver = {
		.shutdown	= ide_drive_shutdown,
	},

to that initializer instead.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/