Re: [PATCH] sis900 fix (Was: [CHECKER] Resource leaks in driver shutdown functions)

From: Rob Landley
Date: Thu May 06 2004 - 12:31:45 EST


On Tuesday 04 May 2004 03:43, Daniele Venzano wrote:
> Thank you for the spotting, the sis900 dirver was really missing a call
> to netif_device_detach in sis900_suspend.
>
> Attached is a trivial patch that fixes the issue.
>
> The sis900 driver is currently unmaintained (the MAINTAINERS address
> bounces), but I'm willing to take the work, since I know somewhat the
> code and I wrote the power management functions.
>
> I no one stands up, I'll send a patch to MAINTAINERS later on.
>
> Bye.

Does this fix the problem where you unplug the cat 5 cable from an SiS900 and
then plug it back in (toggling the MII tranciever link detect status and all
that), and the device goes positively mental until you reboot the system?
(Packets randomly dropped or delayed for up to 15 seconds, and arriving out
of sequence with horrible impacts on performance?)

I tried pursuing this when I first noticed it circa 2.4.4, but as you say, the
driver is unmaintained and I haven't got specs (or any clue about) the
chipset...

Rob

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/