Re: [2.6.6-rc3-mm2] genhd-unregister warn handling

From: Andrew Morton
Date: Thu May 06 2004 - 16:42:20 EST


FabF <Fabian.Frederick@xxxxxxxxx> wrote:
>
> Here's a patch against 2.6.6-rc3-mm2 genhd.c unregister_blkdev
>
> -Standardize function for void xxx
> -Split uncorresponding return
> -Add printks
> -Merge kfree to positive case
>
> Could you apply ?

It seems to be a gratuitous change to the modules API.

A quick grep shows that a lot of drivers are currently testing the
unregister_blkdev() return value - your patch breaks them all.

I don't see much point in making changes in this area.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/