Re: [OPERA] Potential bugs detected by static analysis tool in 2.6.4

From: Luiz Fernando N. Capitulino
Date: Thu May 06 2004 - 19:19:14 EST



Hi Zhenmin,

Em Wed, May 05, 2004 at 10:41:37PM -0500, Zhenmin Li escreveu:

| 9. /drivers/pci/hotplug/shpchp_ctrl.c, Line 1575:
| err("%s: Failed to disable slot, error code(%d)\n", __FUNCTION__, rc);
|
| Maybe change to:
| err("%s: Failed to disable slot, error code(%d)\n", __FUNCTION__, retval);

This seems right to me.

|
| 10. /sound/oss/swarm_cs4297a.c, Line 2019:
| s->dma_adc.blocks = s->dma_dac.wakeup = 0;
|
| Maybe change to:
| s->dma_adc.blocks = s->dma_adc.wakeup = 0;

This don't. At a first look seems that 'dma_adc' and 'dma_dac' is the some
thing typed wrong, but don't, they are not the some thing.

--
Luiz Fernando N. Capitulino
<http://www.telecentros.sp.gov.br>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/