RE: [2.6.6 PATCH] Exposing EFI memory map

[Sourav Sen]

Hi Greg,

+ -----Original Message-----
+ From: Greg KH [mailto:greg@xxxxxxxxx]
+ Sent: Thursday, May 06, 2004 10:11 PM
+ To: Sourav Sen
+ Cc: Matt_Domsch@xxxxxxxx; matthew.e.tolentino@xxxxxxxxx;
+ linux-ia64@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
+ Subject: Re: [2.6.6 PATCH] Exposing EFI memory map
+
+
+ On Thu, May 06, 2004 at 02:22:46PM +0530, Sourav Sen wrote:
+ >
+ > The following simple patch creates a read-only file
+ > "memmap" under <mount point>/firmware/efi/ in sysfs
+ > and exposes the efi memory map thru it.
+
+ No, data in this kind of format does not belong in sysfs.

	Please tell me more. In Documentation/filesystems/sysfs.txt
I get:

"Attributes should be ASCII text files, preferably with only one value
per file. It is noted that it may not be efficient to contain only
value per file, so it is socially acceptable to express an array of
values of the same type."

Here we have "Array of values of same types". And it does not do much
nifty formatting either. Is that not acceptable?

If that is not, how about the following.

	1. Create a directory "memmap" under firmware/efi/
	2. Create files "map_start", "map_size" and "mapdesc_size" under
         that exposing ia64_boot_param->efi_memmap,
ia64_boot_param->efi_memmap_size
	   and ia64_boot_param->efi_memdesc_size respectively.

Userland can make meaning out of them by knowing the values and knowing
about
"efi_memory_desc_t" which is already there in /usr/include/asm/efi.h


Thanks
Sourav

PS: BTW, Your slides on "Dealing with the Linux Kernel Community" at:
http://www.kroah.com/linux/talks/cgl_talk_2002_10_16/mgp00001.html
is kind of useful to me. This is my first time :-)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/