Re: alpha fp-emu vs module refcounting

[Christoph Hellwig]

On Fri, May 07, 2004 at 06:32:08PM +0400, Ivan Kokshaysky wrote:
> -	MOD_INC_USE_COUNT;
> +	BUG_ON(!try_module_get(THIS_MODULE));

This is broken.  If you know you already have a reference somewhere -
and I can't find how that would work - you'd have to use __module_get,
but if it's not you can get a failure from try_module_get legally and
you should do the try_module_get outside the module, before it's code
is exectuted.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/