Re: [PATCH] Format Unit can take many hours

From: Kurt Garloff
Date: Tue May 11 2004 - 11:31:43 EST


On Tue, May 11, 2004 at 06:14:27PM +0200, Jens Axboe wrote:
> On Tue, May 11 2004, Jeff Garzik wrote:
> > Jens Axboe wrote:
> > >block/scsi_ioctl.c should likely receive similar treatment then.
> >
> > This timeout is dependent on media size, I should think...
> >
> > Is there any reason to think that this timeout will _not_ be continually
> > patched in the future, as larger and larger sizes are used?

The disks gets faster as well.

But if we have to touch it every three years, I don't see this as a
huge problem either. If you want some more room, you can set it to
24hrs now ...

> I think the timeout is only used for ancient programs that use the old
> sg interface. Newer programs should pass in the timeout themselves, or
> set IMMED as somebody else in this thread noted.

If you do use the sg interface, you can specify the timeout.
If you use SCSI_IOCTL_SEND_COMMAND, there's no way to do it and
the value from scsi_ioctl.c applies.

scsiformat is one of the users.

> So I do think the easiest is just to patch this define for the odd case,
> and forget about it.


Kurt Garloff <garloff@xxxxxxx> Cologne, DE
SUSE LINUX AG, Nuernberg, DE SUSE Labs (Head)

Attachment: pgp00000.pgp
Description: PGP signature