RE: [RFC] [PATCH] Performance of del_timer_sync

[Chen, Kenneth W]

>>>>> Andrew Morton wrote on Tuesday, May 11, 2004 1:31 PM
> > > +int del_single_shot_timer(struct timer_struct *timer)
> > > +{
> > > +	if (del_timer(timer))
> > > +		del_timer_sync(timer);
> > > +}
> > >  #endif
> >
> > I'm confused, isn't the polarity of del_timer() need to be reversed?
>
> Hey, I didn't compile it, let alone test it!
>
> > Also propagate the return value of del_timer_sync()?
>
> yup.
>
> If it looks OK, please fix it up, kerneldocify the function and prepare
> a real patch?

Looks wonderful, much better than what we had before.  We will consolidate
the comments, run through our test setup and re-post.  Thanks!

- Ken


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/