MSEC_TO_JIFFIES is messed up...

From: Greg KH
Date: Wed May 12 2004 - 13:22:49 EST


On Wed, May 12, 2004 at 02:07:00AM -0700, Andrew Morton wrote:
> drivers/usb/host/ehci.h:599: warning: `MSEC_TO_JIFFIES' redefined
> include/asm/param.h:9: warning: this is the location of the previous definition
> In file included from drivers/usb/host/ohci-hcd.c:127:
> drivers/usb/host/ohci.h:400: warning: `MSEC_TO_JIFFIES' redefined
> include/asm/param.h:9: warning: this is the location of the previous definition

Woah, that's new. And wrong. The code in include/asm-i386/param.h that
says:
# define JIFFIES_TO_MSEC(x) (x)
# define MSEC_TO_JIFFIES(x) (x)

Is not correct. Look at kernel/sched.c for verification of this :)

Looks like we just messed with our carefully tuned scheduler...

We can blame the following changeset from Ingo:

ChangeSet 1.1608.6.15 2004/05/10 13:26:09 akpm@xxxxxxxx
[PATCH] sched: trivial fixes, cleanups

From: Ingo Molnar <mingo@xxxxxxx>

The trivial fixes.

- added recent trivial bits from Nick's and my patches.
- hotplug CPU fix
- early init cleanup


thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/