Re: PCI memory reservation failure - 2.4/2.6

From: Manfred Spraul
Date: Wed May 12 2004 - 16:17:45 EST


Alec H. Peterson wrote:

+ #if 1
+ if (!(type & IORESOURCE_IO) && (((end - start) < BRIDGE_SIZE_MIN) ||
+ (start & (end - start))))
+ {
+ printk(KERN_INFO "yenta %s: Preassigned resource start %lx end %lx too small or not aligned.\n", socket->dev->slot_name, start, end);
+ res->start = res->end = 0;
+ }

I'm not sure if this is the right approach - what if a bios intentionally assigns a small area? It's dangerous to override the BIOS setting.
I'd prefer a kernel command line parameter / module parameter / dmi based override instead of an unconditional override based on the minimum size.
I'll think about it.

--
Manfred

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/