Re: From Eric Anholt:
From: Linus Torvalds
Date: Wed May 12 2004 - 17:34:13 EST
On Wed, 12 May 2004, Dave Airlie wrote:
> I just looked at drm.h and nearly all the ioctls use int, this file is
> included in user-space applications also at the moment, I'm worried
> changing all ints to __u32 will break some of these, anyone on DRI list
> care to comment?
Right now, all architectures have "int" being 32-bit, so nothing should
break. Apart from sign issues, of course.
If there are pointers and "long", then those should just not exist. Never
expose kernel pointers to user mode (and you really never should pass user
pointers back), and "long" should really just be "__u32" instead (since
that is what it is on a 32-bit platform - and if it works there, then it
should work on a 64-bit platform too).
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/