RE: [PATCH] ICH6/6300ESB i2c support
From: Gaston, Jason D
Date: Thu May 13 2004 - 14:58:57 EST
The reason I have the renumbering in pci_ids.h and the new device
support in i2c-i801 in the same patch, is that the new device support is
dependent on the devices being added to pci_ids.h. However, if it is
the consensus that these be two separate patches, I can separate them.
As far as using the ICHx model name is concerned; I can not use the
model name "82801xx" until after the product has launched. I have also
seen requests to use the ICHx name rather then the model number. Again,
if it is the consensus, I can go back after the product launches and
change all of the #defines, for the device, to use the model number
rather than the "common" name.
I will look into providing the same patch for the 2.4 kernel.
Thank you very much for looking at my patch,
From: Jean Delvare [mailto:khali@xxxxxxxxxxxx]
Sent: Thursday, May 13, 2004 1:05 AM
Subject: Re: [PATCH] ICH6/6300ESB i2c support
A few comments on your patch:
> This patch adds DID support for ICH6 and 6300ESB to i2c-i801.c(SMBus).
> order to add this support I needed to patch pci_ids.h with the SMBus
> To keep things orginized I renumbered the ICH6 and ESB entries in
> I then patched the piix IDE and i810 audio drivers to reflect the
> #define's. I also removed an error from irq.c; there was a reference
> 6300ESB DID that does not exist. This patch is against the 2.6.6
To me, there are two different things here and you should split your
patch accordingly for clarity. The renumbering of the entries should go
in a first patch, then the new devices support in i2c-i801 in a second.
I would also suggest that you follow the common habit to name the Intel
82801 chips after their numerical name (82801AA. 82801BA, etc...) and
not their nickname (ICH, ICH2...) in both the entries and the comments.
Not that it is absolulety better, but that's the way we did so far, so
why change now?
I would appreciate it if you could submit a similar patch for the 2.4
version of the i2c-i801 driver as held in the lm_sensors project.
Jean "Khali" Delvare
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/