Re: [PATCH 2.6.6] bootmem.c cleanup

From: Andrew Morton
Date: Fri May 14 2004 - 15:35:37 EST

Michael Buesch <mbuesch@xxxxxxxxxx> wrote:
> - if (!test_and_clear_bit(i, bdata->node_bootmem_map))
> - BUG();
> + BUG_ON(!test_and_clear_bit(i, bdata->node_bootmem_map));

Please don't put expressions whihc actually change state inside BUG_ON().
Someone may decide to make BUG_ON() a no-op to save space.

I'm not aware of anyone actually trying that, but it's a good objective.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at