Re: Linux 2.6.6 "IDE cache-flush at shutdown fixes"

[Greg KH]

On Fri, May 14, 2004 at 11:16:20PM -0700, Andrew Morton wrote:
> Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > Andrew Morton <akpm@xxxxxxxx> wrote:
> > > 
> > > I don't know if it's worth the effort though.  Is any other driver likely
> > > to want to discriminate between reboot and shutdown?
> > 
> > e100 used to (and still does in 2.4) send the device into D3 on shutdown.
> > This causes problems on a number of boards if the box is only rebooting
> > as the driver fails to bring the device back out of D3.
> 
> Ho hum.  Greg, any preferences?  We can either:
> 
> a) Add a `restart' driver method and call that during reboot instead of
>    ->shutdown, if the driver implements ->restart.  Otherwise call
>    ->shutdown or
> 
> b) stick with the
> 
> 	if (system_state == SYSTEM_RESTART)
> 		...
> 
>    thing in IDE and potentially a couple of other places?

I think we should stick with option b) for now, as we are already
keeping this system state, right?  The number of different drivers that
will care about this is probably quite small.

But if I'm proven wrong, we can add "restart" to 2.7 :)

thanks,

greg k-h

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/