Re: swsusp: fix swsusp with intel-agp

From: Pavel Machek
Date: Fri May 21 2004 - 06:45:02 EST


Hi!

> > > > > --- tmp/linux/arch/i386/mm/init.c 2004-05-20 23:08:05.000000000 +0200
> > > > > +++ linux/arch/i386/mm/init.c 2004-05-20 23:10:50.000000000 +0200
> > > > > @@ -331,6 +331,13 @@
> > > > > void zap_low_mappings (void)
> > > > > {
> > > > > int i;
> > > > > +
> > > > > +#ifdef CONFIG_SOFTWARE_SUSPEND
> > > >
> > > > Can you please define this for CONFIG_PM_DISK as well? Alternatively,
> > > > you can do the same as you did in cpu.c and define this for
> > > > CONFIG_PM.
>
> Would you object to a patch that converted current uses of
> CONFIG_SOFTWARE_SUSPEND/CONFIG_PM to a new symbol that is
> turned on iff one of CONFIG_SOFTWARE_SUSPEND/CONFIG_PM_DISK
> is enabled?

I guess that open-coding #if defined() || defined() is right thing to
do for now.

Suspend2 when/if merged might not need this... This one is not really
specific to suspend-to-disk. It is specific to swsusp way of doing
things, which happens to be same as pmdisk way of doing it...
Pavel
--
934a471f20d6580d5aad759bf0d97ddc
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/