Re: [linux-usb-devel] [PATCH] visor: Fix Oops on disconnect

[nardelli]

Pete Zaitcev wrote:
> On Thu, 20 May 2004 21:30:32 -0700
> Greg KH <greg@xxxxxxxxx> wrote:
>
>
> > > -	if (!port->read_urb) {
> > > +	if ((serial->dev->descriptor.idVendor != SONY_VENDOR_ID && !port->read_urb))
> > > +	{
>
>
> > Your patch says that we might not have a read_urb for the given port?
> > How could that be true?  The check here in open() will catch any devices
> > that this might not be correct for.  So that portion of this patch is
> > not needed, right?
>
>
> I know nothing about Palms, but also that part contradicted a comment.
>
> -	if (!port->read_urb) {
> +	if ((serial->dev->descriptor.idVendor != SONY_VENDOR_ID && !port->read_urb))
> +	{
>  		/* this is needed for some brain dead Sony devices */
>
> So.... the patch makes the body of the if to be used when it's NOT Sony,
> but the comment says that it's intended for Sony. I think it's fishy.

Oops - that does look a little fishy.  I'll revisit.

> -- Pete


--
Joe Nardelli
jnardelli@xxxxxxxxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/