Re: [PCMCIA] Check return status of register calls in i82365

[Herbert Xu]

On Fri, May 21, 2004 at 04:41:11PM -0700, Andrew Morton wrote:
> Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > i82365 calls driver_register and platform_device_register without
> > checking their return values.  This patch fixes that.
> 
> It does more than that - you've also changed it to run platform_device_register()
> prior to isa_probe().  How come?

1. The platform device being registered is a place-holder that does not
   rely on the probing at all.
2. If it was done after the probe then should the registration fail, we'll
   have to roll back all the changes done by isa_probe().

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/