Re: 2.6.6-mm5 oops mounting ext3 or reiserfs with -o barrier

[Jens Axboe]

On Sat, May 22 2004, Jens Axboe wrote:
> On Sat, May 22 2004, Andrew Morton wrote:
> > Lorenzo Allegrucci <l_allegrucci@xxxxxxxxxxxxx> wrote:
> > >
> > > 
> > > I get a 100% reproducible oops mounting an ext3 or reiserfs
> > > partition with -o barrier enabled.
> > > Hand written oops (for ext3):
> > 
> > That's a lot of hand-writing.  Thanks for doing that.  You can usually omit
> > the hex numbers in [brackets] when doing this.
> > 
> > The crash is here:
> > 
> > static inline void blkdev_dequeue_request(struct request *req)
> > {
> > 	BUG_ON(list_empty(&req->queuelist));
> > 
> > perhaps related to that I/O error sending the code through less-tested
> > paths.
> 
> Ouch indeed, I'll get that fixed up first thing in the morning.

Can you test this work-around? The work-around should be perfectly safe,
this is just a case where a BUG_ON() does more harm than good :-)

--- drivers/ide/ide-io.c~	2004-05-21 11:02:58.000000000 +0200
+++ drivers/ide/ide-io.c	2004-05-22 23:28:37.692944185 +0200
@@ -291,6 +291,8 @@
 		sector = real_rq->hard_sector;
 
 	bad_sectors = real_rq->hard_nr_sectors - good_sectors;
+	/* work-around, make sure request is on queue */
+	elv_requeue_request(drive->queue, real_rq);
 	if (good_sectors)
 		__ide_end_request(drive, real_rq, 1, good_sectors);
 	if (bad_sectors)

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/