Re: [Prism54-devel] Re: [PATCH 0/14] prism54: bring up to sync withprism54.org cvs rep
From: Jeff Garzik
Date: Thu May 27 2004 - 14:26:47 EST
Andrew Morton wrote:
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
Luis, you, or somebody should create a new patch series with just the
critical fixes, NO WHITESPACE/FORMATTING CHANGES mixed in, and send
Whitespace changes are often nice, but they should be the very first
patch[es] in the series. You should be able to verify that the .o file was
unchanged before and after.
Very first, or very last. I leave that up to the maintainer.
That way they become a no-brainer and it becomes easier to review and
understand the substantive changes.
Further, when someone mixes an Lindent in with functional changes, I
become very suspicious. That is precisely the method that certain high
profile Linux hackers have used in the past to intentionally obfuscate
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/