Re: [3/4] [PATCH]Diskdump - yet another crash dump function

From: Andi Kleen
Date: Thu May 27 2004 - 16:32:36 EST


Ingo Molnar <mingo@xxxxxxx> writes:

> yeah, this is arguably the biggest (and i think only) conceptual item
> that needs to be solved before this can be integrated.

I would think netdump is more important than this though
(so if anything should be integrated i would start with netdump)

> it would also be easier to enable diskdump in a driver if this was
> handled in add_timer()/del_timer()/mod_timer()/tasklet_schedule().

I don't think it's a good idea to add this to these fast paths.
Timers are critical for lots of things, tasklet_schedule too.

How about a standard wrapper that does the check and everybody
who may need that uses the wrappers ?

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/