Re: libata regression 2.6.6-rc1 -> 2.6.6-rc2 located

[Jeff Garzik]

Brad Campbell wrote:
> diff -urN linux-2.6.5-a/drivers/scsi/sata_promise.c 
> linux-2.6.5-b/drivers/scsi/sata_promise.c
> --- linux-2.6.5-a/drivers/scsi/sata_promise.c   2004-05-29 
> 19:53:40.000000000 +0400
> +++ linux-2.6.5-b/drivers/scsi/sata_promise.c   2004-05-29 
> 19:41:47.000000000 +0400
> @@ -1180,14 +1180,14 @@
>
>  static void pdc_tf_load_mmio(struct ata_port *ap, struct ata_taskfile *tf)
>  {
> -       if (tf->protocol != ATA_PROT_DMA)
> +       if (tf->protocol == ATA_PROT_PIO)
>                 ata_tf_load_mmio(ap, tf);
>  }
>
>
>  static void pdc_exec_command_mmio(struct ata_port *ap, struct 
> ata_taskfile *tf)
>  {
> -       if (tf->protocol != ATA_PROT_DMA)
> +       if (tf->protocol == ATA_PROT_PIO)
>                 ata_exec_command_mmio(ap, tf);
>  }

Great work, thanks.

Short term, I'll revert this patch.  The change was more of a 
"preparation for the future", and not strictly required.

I think I understand why, but I'll need to ponder a bit more on the long 
term solution.

	Jeff




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/