Re: PATCH: First cut at fixing the 3c59x power mismanagment

[Jeff Garzik]

Alan Cox wrote:
> In Fedora 2 there have been lots of problem reports with 3c59x mostly 
> apparently linked to power handling errors. In particular tools query the
> MII state of down interfaces.
>
> The changes here
>
> -	Power the chip up when doing MII, much as e100 does
> -	Fix a case where the error handling issued commands to the chip
> 	while it was in D3 state
> -	Fixed a case where shutdown handling issued commands to the chip
> 	while it was in D3 state
>
> I don't have enough suitable hardware to do good coverage testing on these
> changes so test reports would be appreciated.


Initial review of the patch looks good, FWIW.

Thanks for poking at this,

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/