Re: Linux 2.6.7-rc2

[Andrew Morton]

Peter Osterlund <petero2@xxxxxxxxx> wrote:
>
>  If I put "#if 0" around the *wdata assignment in nfs_writepage_sync,
>  the stack usage goes down to 36, so it looks like gcc is building a
>  temporary structure on the stack and then copies the whole thing to
>  *wdata.

aww, crap.

>  Does this construct save stack space for any version of gcc? Maybe the
>  code should be changed to do a memset() followed by explicit
>  initialization of the non-zero member variables instead.

yes, we should do that.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/