Re: submit_bh leaves interrupts on upon return

From: Jens Axboe
Date: Thu Jun 03 2004 - 03:52:04 EST


On Wed, Jun 02 2004, Jeff V. Merkey wrote:
>
> Any reason why submit_bh should turn on interrupts after being called by
> a process with ints off in 2.4.20? I see it's possible to sleep during
> elevatoring, but why does it need to leave interrupts on if the calling
> state was with ints off.

It's illegal to call it with interrupts off, so... __make_request()
doesn't save interrupt state, so you will always leave with interrupts
enabled.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/