Re: Linux 2.6.7-rc2

From: Flavio Stanchina
Date: Thu Jun 03 2004 - 15:03:00 EST


Peter Osterlund wrote:
[patch to linux/fs/nfs/read.c]
+ memset(rdata, 0, sizeof(*rdata));
+ rdata->flags = (IS_SWAPFILE(inode)? NFS_RPC_SWAPFLAGS : 0);

Wouldn't this be better as:
if (IS_SWAPFILE(inode))
rdata->flags = NFS_RPC_SWAPFLAGS;

+ rdata->args.pgbase = 0UL;

Wouldn't this be redundant?

--
Ciao, Flavio

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/