Re: [PATCH] cpumask 5/10 rewrite cpumask.h - single bitmap based implementation

From: William Lee Irwin III
Date: Fri Jun 04 2004 - 11:58:52 EST


Mikael writes:
>> Case in point: the perfctr kernel extension needs to communicate ...

On Fri, Jun 04, 2004 at 09:03:14AM -0700, Paul Jackson wrote:
> Nice example. Thank-you.
> Yes - doing that 1-bit at a time in a per-cpu loop would be ugly.
> We should leave cpus_addr() around, at least until such time as the
> cpumask ADT provided routines to support exactly what you are doing -
> copying up masks to user space as length specified arrays of uint.

This is patently ridiculous. Make a compat_sched_getaffinity(), and
likewise for whatever else is copying unsigned long arrays to userspace.


-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/