Re: [PATCH] compat bug in sys_recvmsg, MSG_CMSG_COMPAT checkmissing

From: David S. Miller
Date: Sat Jun 05 2004 - 16:40:38 EST


On Sat, 05 Jun 2004 23:21:53 +0200
Andreas Schwab <schwab@xxxxxxx> wrote:

> "David S. Miller" <davem@xxxxxxxxxx> writes:
>
> > This means also that Olaf's patch is broken, when CONFIG_COMPAT is not
> > set, MSG_CMSG_COMPAT is zero, thus ~MSG_CMSG_COMPAT is the unexpected
> > value all 1's thus breaking the tests for unexpected flags completely.
>
> ??? Where do you get ~MSG_CMSG_COMPAT from?

Olaf's patch, it said:

- if (flags & ~(MSG_PEEK|MSG_DONTWAIT|MSG_TRUNC))
+ if (flags & ~(MSG_PEEK|MSG_DONTWAIT|MSG_TRUNC|MSG_CMSG_COMPAT))
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/