Re: [BUG] asm-ppc/pgtable.h breakage from 2.6.7-rc1-bk4

From: Benjamin Herrenschmidt
Date: Sun Jun 06 2004 - 15:51:44 EST


Ok, please tell me if this patch works, I don't have a machine
to test here. If it's ok, I'll send it to andrew/linus.

===== include/asm-ppc/pgtable.h 1.33 vs edited =====
--- 1.33/include/asm-ppc/pgtable.h 2004-05-26 09:56:17 -05:00
+++ edited/include/asm-ppc/pgtable.h 2004-06-06 15:45:24 -05:00
@@ -555,8 +555,14 @@
(_PAGE_DIRTY | _PAGE_ACCESSED | _PAGE_RW);
pte_update(ptep, 0, bits);
}
+
+extern void flush_one_tlb_entry_nohash(unsigned long addr);
+
#define ptep_set_access_flags(__vma, __address, __ptep, __entry, __dirty) \
- __ptep_set_access_flags(__ptep, __entry, __dirty)
+ do { \
+ __ptep_set_access_flags(__ptep, __entry, __dirty); \
+ flush_one_tlb_entry_nohash(__address); \
+ } while(0)

/*
* Macro to mark a page protection value as "uncacheable".
===== arch/ppc/mm/tlb.c 1.10 vs edited =====
--- 1.10/arch/ppc/mm/tlb.c 2004-02-04 23:00:14 -06:00
+++ edited/arch/ppc/mm/tlb.c 2004-06-06 15:44:05 -05:00
@@ -67,6 +67,17 @@
}

/*
+ * Called by ptep_set_access_flags, must flush on CPUs for which the
+ * DSI handler can't just "fixup" the TLB on a write fault
+ */
+void flush_one_tlb_entry_nohash(unsigned long addr)
+{
+ if (Hash != 0)
+ return;
+ _tlbie(vmaddr);
+}
+
+/*
* Called at the end of a mmu_gather operation to make sure the
* TLB flush is completely done.
*/


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/