Re: [VGA16FB] Fix bogus mem_start value

From: Andrew Morton
Date: Tue Jun 08 2004 - 05:12:49 EST


Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
>
> The recent change to vga16fb's memory mapping that you partially
> reverted is still broken. In particular, it's setting fix.mem_start
> to a virtual address on i386. The value of fix.mem_start is meant
> to be physical.

Sigh. Fiasco.

> We could simply apply virt_to_phys to it, but somehow I doubt that
> is what it's meant to do on arm. So until we hear from someone who
> knows how it works on arm, let's just revert this change.

Is this tested?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/