Re: intel-agp: skip non-AGP devices

From: Matt Domsch
Date: Tue Jun 08 2004 - 11:03:17 EST


On Tue, Jun 01, 2004 at 05:31:00PM +0100, Dave Jones wrote:
> On Tue, Jun 01, 2004 at 05:20:58PM +0100, Christoph Hellwig wrote:
>
> > > The patch below checks for a valid cap_ptr prior to printing the
> > > message, now at KERN_WARNING level (it's not really an error, is it?)
> >
> > The real problem is that agpgart doesn't properly fill in the pci_id
> > table but claims all devices and then does it's own probing internally.
> > This also breaks hotplug in a funny way.
>
> This is fixed in agpgart-bk / -mm. Andi went through all the drivers
> adding their id's. Should be going to Linus soon.
>
> Dave

FWIW, sworks-agp.c has the same issue in mainline yet today.
agpgart: Unsupported Serverworks chipset (device id: 0011)
agpgart: Unsupported Serverworks chipset (device id: 0201)

I'll look at -mm to verify it's fixed there.

Thanks,
Matt

--
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com

Attachment: pgp00000.pgp
Description: PGP signature