Re: PATCH: ethtool power manglement hooks

From: Jeff Garzik
Date: Tue Jun 08 2004 - 13:05:15 EST


Alan Cox wrote:
Several ethernet drivers have been broken by the ethtool support because
the ioctl code used to power the interface up and down as needed. Rather


To be more specific, the new ethtool_ops feature bypasses code in net drivers which did one of two things:
* power up the hardware, perform the ioctl, and power down the hardware
or
* fail if netif_running() is false, indicating the driver's requirement that MII and ethtool operations only occur when the interface is up (thereby ignoring the power management issues)


Also, CC net driver patches to me and netdev, pretty please with sugar on it.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/