Re: [PATCH] fix warnings in drivers/mtd/devices/doc200?.c

[David Woodhouse]

On Wed, 2004-06-09 at 02:24 +0200, Jesper Juhl wrote:
> I must admit that I do not know what the purpose of "oobsel" is, nor do I
> know very much about these functions or mtd devices in general, but since
> the doc_*_ecc functions do not use the oobsel parameter at all I still
> think I can propose a safe fix by simply changing the functions to take a
> struct nand_oobinfo *  argument instead of their current  int  argument.
> Comments??

That works, but please don't do it without also adding something like:

#warning This driver should be updated to the new ECC API.

Or you could just leave the warning we already have :)

It works at the moment because the only thing that _uses_ the driver in
question is something which also doesn't use the new argument. We're
working on a new driver and at that point we'll also update the code
which uses it.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/