Re: Unaligned accesses in net/ipv4/netfilter/arp_tables.c:184

From: Alex Williamson
Date: Wed Jun 09 2004 - 15:31:46 EST


On Wed, 2004-06-09 at 14:00, David S. Miller wrote:
> On Wed, 09 Jun 2004 12:27:56 -0600
> Alex Williamson <alex.williamson@xxxxxx> wrote:
>
> > http://marc.theaimsgroup.com/?l=netfilter-devel&m=107814727803971&w=2
>
> How can you legitimately change this structure? It's an exported
> userland interface, if you change it all the applications will
> stop working.
>

Which is probably why the patch never went anywhere. There's
certainly an alignment issue in the usage of the struct arpt_arp in the
code snippet Christoph pointed out. Sounds like it'd be better to fix
the usage than the structure alignment.

Alex

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/