Re: Fix memory leak in swsusp

[Pavel Machek]

Hi!

> > @@ -803,32 +804,31 @@
> >  		return 0;
> >  	}
> >  
> > +	err = -ENOMEM;
> >  	while ((m = (void *) __get_free_pages(GFP_ATOMIC, pagedir_order))) {
> >  		memset(m, 0, PAGE_SIZE);
> 
> BTW, what does this memset do?

Someone (me?) was trying to be carefull, and was not carefull enough.
AFAICS it should be memset(..., PAGE_SIZE << pagedir_order)
-- 
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms         

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/