Re: Fix memory leak in swsusp

[Herbert Xu]

On Thu, Jun 10, 2004 at 11:24:48PM +0200, Pavel Machek wrote:
> > > @@ -803,32 +804,31 @@
> > >  		return 0;
> > >  	}
> > >  
> > > +	err = -ENOMEM;
> > >  	while ((m = (void *) __get_free_pages(GFP_ATOMIC, pagedir_order))) {
> > >  		memset(m, 0, PAGE_SIZE);
> > 
> > BTW, what does this memset do?
> 
> Here's incremental fix, it compiles but not tested.

Thanks, but my question remains: why do we need the memset?  The
area allocated is either thrown away because it collides or is
overwritten with the pagedir stuff straight away.

> BTW I have problems getting mail to you:

Sorry, that should be fixed now.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/