Re: [PATCH]Re:2.6.7-rc3-mm1

From: William Lee Irwin III
Date: Thu Jun 10 2004 - 20:07:47 EST


On Wed. June 09, 2004 William Lee Irwin III wrote:
>> The MSI writers have a lot to answer for. Could you test this?

On Thu, Jun 10, 2004 at 01:45:13PM -0700, long wrote:
> The MSI patch has existed in the kernel since 2.6.3 and has been
> validated in both UP and SMP environments. It appears another patch
> (don't know which one) redefined the value of TARGET_CPU, which is
> used by the function msi_address_init() to configure logical
> target CPU. The redefinition of TARGET_CPU without checking its
> usage by other kernel code broke the build.
> Your patch fixes the build but breaks the devices using MSI in
> different architectures supported by the function msi_address_init().
> I have attached a patch that fixes the build and maintains cross
> architecture support for MSI.

I didn't know it was a logical APIC ID that was supposed to go in there.
Well, that ought to fix bugs with MSI and clustered hierarchical DFR too.


-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/