Re: [linux-usb-devel] Re: Finding user/kernel pointer bugs [no html]

From: Greg KH
Date: Fri Jun 11 2004 - 11:38:31 EST


On Fri, Jun 11, 2004 at 06:31:07AM +0200, Luca Risolia wrote:
> > unsigned int cmd, void* arg)
> > {
> > struct w9968cf_device* cam;
> > + void __user *user_arg = (void __user *)arg;
>
> The right place to apply this patch is in video_usercopy().

Um, the driver you just refered to does not use the video_usercopy()
function so your email doesn't make much sense in this context.

> Please have a look at definition of the function in videodev.c.

Please excuse me while I go get sick...

Anyway, that function needs to be properly marked up with __user if you
want it to live.

good luck,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/