Re: [PATCH 1/4]Diskdump Update

From: Takao Indoh
Date: Sun Jun 13 2004 - 20:38:24 EST


Hi,

On Fri, 11 Jun 2004 08:17:40 -0700, "Martin J. Bligh" wrote:

>> Ok, I fix it.
>>
>> - page = mem_map + nr;
>> + page = pfn_to_page(nr);
>
>That's correct now ...
>
>> I also need fix this.
>>
>> - for (nr = 0; nr < max_mapnr; nr++) {
>> + for (nr = 0; nr < max_pfn; nr++) {
>
>... but that's not (at least AFAICS from this snippet). You need to iterate
>over pgdats, and then over the lmem_map inside each pgdat.

How about this?

for_each_pgdat(pgdat) {
for (i = 0; i < pgdat->node_spanned_pages; ++i) {
page = pgdat->node_mem_map + i;
...
}
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/