[PATCH] proper bios handoff in ehci-hcd

From: Gary_Lerhaupt
Date: Mon Jun 14 2004 - 15:32:08 EST


Stuart Hayes here at Dell has identified this or/and mix-up in the ehci-hcd driver. Because of this, ehci-hcd is not properly released by BIOSes supporting full 2.0 and port behavior can then become erratic.

This is broken in latest 2.4 and 2.6.

Gary Lerhaupt
Dell Linux Development
http://linux.dell.com

--- linux/drivers/usb/host/ehci-hcd.c.orig 2004-06-05 03:12:18.000000000 -0500
+++ linux/drivers/usb/host/ehci-hcd.c 2004-06-05 01:18:51.000000000 -0500
@@ -290,7 +290,7 @@ static int bios_handoff (struct ehci_hcd
int msec = 500;

/* request handoff to OS */
- cap &= 1 << 24;
+ cap |= 1 << 24;
pci_write_config_dword (ehci->hcd.pdev, where, cap);

/* and wait a while for it to happen */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/