Re: [PATCH] Fix ppc64 out_be64

[Benjamin Herrenschmidt]

On Mon, 2004-06-14 at 15:26, Roland Dreier wrote:
>     Benjamin> Well, I may know ppc asm, but gcc inline asm still
>     Benjamin> drives me nuts :)
> 
> Speaking of gcc asm, is there a reason why out_le64 (specifically the
> constraints) isn't written in this (simpler) way?  It seems to me we
> can just let val be an input, as long as the "&" constraint for tmp
> makes sure it doesn't share the same register.  This seems to generate
> the same code for me as the current kernel version, at least with gcc
> 3.4.0/binutils 2.15.

Hrm... and addr too .. well, I'm just paranoid about those constraints,
I never took the time to fully understand how gcc deals with them
and got bitten by them often enough. I'd rather keep the version that
just works at this point ;)

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/