Re: [PATCH] security_sk_free void return fixup

From: Andrew Morton
Date: Tue Jun 15 2004 - 22:14:53 EST


Linus Torvalds <torvalds@xxxxxxxx> wrote:
>
>
>
> On Tue, 15 Jun 2004, Chris Wright wrote:
> >
> > CHECK net/core/sock.c
> > include/linux/security.h:2636:39: warning: return expression in void function
> > CC net/core/sock.o
>
> I'm going to remove this warning from sparse. Apparently it is valid C99,

yes, but in every(?) case where it triggered, the kernel code was wrong.
So I'd suggest the warning be retained, perhaps with an option to enable
it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/